BC Wallet deep link display #421
Merged
+298
−121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas ONeil <[email protected]>
Signed-off-by: Lucas ONeil <[email protected]>
loneil
force-pushed
the
feature/bcWalletDeepLink
branch
from
bd87625 to
61a80b1
Compare
Signed-off-by: Lucas ONeil <[email protected]>
Signed-off-by: Lucas ONeil <[email protected]>
Signed-off-by: Lucas ONeil <[email protected]>
loneil
changed the title
Signed-off-by: Lucas ONeil <[email protected]>
esune
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add capability of displaying a deep link specific to the BC Wallet app. On devices that can have the app (iOS, Android) show the Deep link as the main option, with an ability to get a QR code as well.
See Kim's mockups here for UI/UX https://xd.adobe.com/view/b40869d2-5fff-40ff-855c-ace0d1da0c30-e15b/
Additionally, change the flow to generate the presentation request message contents when the controller loads (and creates the QR code and deep link), rather than waiting until the short QR link is called back to.
This message content is stored with the auth_session document in the mongo collection, so that it is fetched instead of generated on that QR callback.